Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused test fixture #373

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Remove unused test fixture #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions tests/test_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ def example_tag():
return tags.Tag("py3", "none", "any")


@pytest.fixture
def is_x86():
return re.match(r"(i\d86|x86_64)", platform.machine()) is not None


@pytest.fixture
def manylinux_module(monkeypatch):
monkeypatch.setattr(tags, "_get_glibc_version", lambda *args: (2, 20))
Expand Down Expand Up @@ -503,7 +498,7 @@ def test_linux_platforms_manylinux_unsupported(self, monkeypatch):
linux_platform = list(tags._linux_platforms(is_32bit=False))
assert linux_platform == ["linux_x86_64"]

def test_linux_platforms_manylinux1(self, is_x86, monkeypatch):
def test_linux_platforms_manylinux1(self, monkeypatch):
monkeypatch.setattr(
tags, "_is_manylinux_compatible", lambda name, *args: name == "manylinux1"
)
Expand All @@ -514,7 +509,7 @@ def test_linux_platforms_manylinux1(self, is_x86, monkeypatch):
arch = platform.machine()
assert platforms == ["manylinux1_" + arch, "linux_" + arch]

def test_linux_platforms_manylinux2010(self, is_x86, monkeypatch):
def test_linux_platforms_manylinux2010(self, monkeypatch):
monkeypatch.setattr(distutils.util, "get_platform", lambda: "linux_x86_64")
monkeypatch.setattr(platform, "machine", lambda: "x86_64")
monkeypatch.setattr(os, "confstr", lambda x: "glibc 2.12", raising=False)
Expand All @@ -535,7 +530,7 @@ def test_linux_platforms_manylinux2010(self, is_x86, monkeypatch):
]
assert platforms == expected

def test_linux_platforms_manylinux2014(self, is_x86, monkeypatch):
def test_linux_platforms_manylinux2014(self, monkeypatch):
monkeypatch.setattr(distutils.util, "get_platform", lambda: "linux_x86_64")
monkeypatch.setattr(platform, "machine", lambda: "x86_64")
monkeypatch.setattr(os, "confstr", lambda x: "glibc 2.17", raising=False)
Expand Down