Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should markers ignore case when comparing packages? #507

Closed
jeroendecroos opened this issue Feb 8, 2022 · 2 comments
Closed

Should markers ignore case when comparing packages? #507

jeroendecroos opened this issue Feb 8, 2022 · 2 comments

Comments

@jeroendecroos
Copy link
Contributor

In pypa/pip#10889 I found that markers are not matched when requesting an extra that has uppercase (as is defined in the package)
e.g.:

wheel:

$ rg Mustache gitchangelog-3.0.4
gitchangelog-3.0.4/gitchangelog-3.0.4.dist-info/METADATA
26:Provides-Extra: Mustache
27:Requires-Dist: pystache; extra == 'Mustache'

Trying to install this with extras:

$ pip install gitchangelog[Mustache]
Collecting gitchangelog[mustache]
  Downloading https://files.pythonhosted.org/packages/9d/f9/554f9d1e2031a330148299b81ed7d6d5f1ef8969154384ca4ae8dd403b7a/gitchangelog-3.0.4-py2.py3-none-any.
whl (54kB)
     |████████████████████████████████| 61kB 7.9MB/s
  Ignoring pystache: markers 'extra == "Mustache"' don't match your environment
Installing collected packages: gitchangelog
Successfully installed gitchangelog-3.0.4

I've found a fix and will open up a PR

jeroendecroos added a commit to jeroendecroos/packaging that referenced this issue Feb 8, 2022
When matching the markers we should makes sure we match case insensitive.
jeroendecroos added a commit to jeroendecroos/packaging that referenced this issue Feb 8, 2022
jeroendecroos added a commit to jeroendecroos/packaging that referenced this issue Feb 8, 2022
jeroendecroos added a commit to jeroendecroos/packaging that referenced this issue Feb 8, 2022
@pradyunsg
Copy link
Member

pradyunsg commented Feb 16, 2022

Please don't mention issue numbers in commits. They result in spam on the issue, as above, and are generally not particularly useful since commits from merged PRs will hold a reference to the relevant PR in the commit page.

@jeroendecroos
Copy link
Contributor Author

Issue was solved with the implementation of PEP 685 (#526)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants