-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should markers ignore case when comparing packages? #507
Labels
Comments
jeroendecroos
added a commit
to jeroendecroos/packaging
that referenced
this issue
Feb 8, 2022
When matching the markers we should makes sure we match case insensitive.
jeroendecroos
added a commit
to jeroendecroos/packaging
that referenced
this issue
Feb 8, 2022
jeroendecroos
added a commit
to jeroendecroos/packaging
that referenced
this issue
Feb 8, 2022
jeroendecroos
added a commit
to jeroendecroos/packaging
that referenced
this issue
Feb 8, 2022
Please don't mention issue numbers in commits. They result in spam on the issue, as above, and are generally not particularly useful since commits from merged PRs will hold a reference to the relevant PR in the commit page. |
Issue was solved with the implementation of PEP 685 (#526) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In pypa/pip#10889 I found that markers are not matched when requesting an extra that has uppercase (as is defined in the package)
e.g.:
wheel:
Trying to install this with extras:
I've found a fix and will open up a PR
The text was updated successfully, but these errors were encountered: