Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add unicode test for filename parsing #388

Closed
pradyunsg opened this issue Jan 20, 2021 · 1 comment · Fixed by #863
Closed

Re-add unicode test for filename parsing #388

pradyunsg opened this issue Jan 20, 2021 · 1 comment · Fixed by #863
Labels
enhancement good first issue packaging.utils

Comments

@pradyunsg
Copy link
Member

I tried to add a test for the Unicode case, but Python 2 made me cry, so I just dropped it. If anyone can tell me how I'd do that cleanly, I'm happy to add it back, but it's a bit of a corner case, so I'm not too worried. (My first thought was to slap a u"..." around the string, but I don't know if the type annotations would approve...)

Originally posted by @pfmoore in #387 (comment)

Once we drop Python 2, this should be a case of reverting d3388aa. :)
@Siddhesh-Agarwal
Copy link
Contributor

Hey, is this issue up for grabs? I see that python 2 support has been dropped

Siddhesh-Agarwal added a commit to Siddhesh-Agarwal/packaging that referenced this issue Dec 26, 2024
@Siddhesh-Agarwal
fix for pypa#388
e99c029
@brettcannon brettcannon mentioned this issue Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue packaging.utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-add a test for Unicode file name parsing Siddhesh-Agarwal/packaging
3 participants
@brettcannon @pradyunsg @Siddhesh-Agarwal