Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specification for dependency specifiers #1177

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Conversation

konstin
Copy link
Contributor

@konstin konstin commented Dec 6, 2022

This moves PEP 508 to packaging.python.org as discussed on discord

Diff between PEP 508 and dependency-specifiers.rst: https://gist.github.com/konstin/059c0e72ff77049e0eb2ce0d738990fd. I've removed the PEP-specific paragraphs, added an introductory sentence and s/this PEP/this document/g.

@bhrutledge
Copy link
Contributor

@konstin Thanks for this. I don't feel qualified to review this, and I don't follow Discord. Do you have a sense of who from that discussion would be a good reviewer? And/or, can you provide a link to that discussion?

@konstin
Copy link
Contributor Author

konstin commented Dec 6, 2022

Either @brettcannon or @pradyunsg probably

@konstin
Copy link
Contributor Author

konstin commented Dec 6, 2022

I got a CI failure email for https://github.com/pypa/packaging.python.org/actions/runs/3629838663/jobs/6122501649 but unfortunately i don't understand how this relates to this PR or why it failed (all checks on this PR seem to pass?)

@bhrutledge
Copy link
Contributor

I got a CI failure email for https://github.com/pypa/packaging.python.org/actions/runs/3629838663/jobs/6122501649 but unfortunately i don't understand how this relates to this PR or why it failed (all checks on this PR seem to pass?)

Yeah, not sure what's going on here; see #1178. FYI @webknjaz

Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is mostly a wholesale copying of PEP 508, so I'm reviewing it just from a perspective of not losing key details from what was previous here.

source/specifications/dependency-specifiers.rst Outdated Show resolved Hide resolved
@konstin
Copy link
Contributor Author

konstin commented Dec 6, 2022

I'm assuming this is mostly a wholesale copying of PEP 508, so I'm reviewing it just from a perspective of not losing key details from what was previous here.

yes, i've included the gist link at the top so you can review the exact section-by-section differences from the document vs. the original PEP 508.

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this and we can iterate on this as we see fit. :)

@pradyunsg pradyunsg changed the title Add PEP 508 Add reference for dependency specifiers Dec 7, 2022
@pradyunsg pradyunsg changed the title Add reference for dependency specifiers Add specification for dependency specifiers Dec 7, 2022
@pradyunsg pradyunsg enabled auto-merge (squash) December 7, 2022 21:59
@pradyunsg pradyunsg disabled auto-merge December 7, 2022 21:59
@pradyunsg pradyunsg enabled auto-merge (squash) December 7, 2022 22:00
konstin and others added 3 commits December 7, 2022 22:00
This moves PEP 508 to packaging.python.org as discussed on discord

Diff between [PEP 508](https://github.com/python/peps/blob/1a87312fb30f86e7690c033574e5f6a2767035f9/pep-0508.txt) and dependency-specifiers.rst: https://gist.github.com/konstin/059c0e72ff77049e0eb2ce0d738990fd
Co-authored-by: Brett Cannon <brett@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants