Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that token-based upload is supported #602

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Document that token-based upload is supported #602

merged 2 commits into from
Oct 20, 2022

Conversation

Mariatta
Copy link
Contributor

@Mariatta Mariatta commented Oct 4, 2022

Closes #276

@Mariatta Mariatta mentioned this pull request Oct 4, 2022
Closed
pradyunsg
pradyunsg approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mariatta!

joukewitteveen
joukewitteveen reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@joukewitteveen joukewitteveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this needs to be in the flit documentation, since it is not specific to flit.

@Mariatta @joukewitteveen
Update doc/cmdline.rst
a10e1e7 
Co-authored-by: Jouke Witteveen <j.witteveen@gmail.com>
@Mariatta
Copy link
Contributor Author

Mariatta commented Oct 6, 2022

I was publishing using flit, and it was not obvious to me that I could use the PyPI token instead of regular username/password. Additionally, while searching for "upload using token with flit" I came across this open issue on GitHub which made me think that it was not supported. So I thought that it would be better to explicitly document it.

@pradyunsg
Copy link
Member

pradyunsg commented Oct 7, 2022 •
edited
Loading

To err on the side of overcommunicating, I'm unlikely to be merging this PR myself, even though I've reviewed and approved it.

I have a green tick cos I'm an admin on pypa but I'm not a committer to twine, and would prefer that someone who is lands this instead. :)

@takluyver takluyver added this to the 3.8 milestone Oct 20, 2022
@takluyver
Copy link
Member

Thanks @Mariatta !

@pradyunsg FWIW, I'm happy for you to merge something like this if you're comfortable doing so.

@takluyver takluyver merged commit db45ff0 into pypa:main Oct 20, 2022
@Mariatta Mariatta deleted the patch-1 branch December 5, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joukewitteveen joukewitteveen joukewitteveen left review comments

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.

support token-based upload to PyPI
4 participants
@Mariatta @pradyunsg @takluyver @joukewitteveen