sysconfig: skip customize_compiler() with MSVC Python again #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that setuptools with mingw support is on pypi, this uncovered the same issue as fixed in 2317473 when pip installing MarkupSafe. Apply the same work around here too.
By enabling customize_compiler() when using the mingw compiler class in 2ad8784 this also enabled it for when the mingw compiler class was used with a MSVC built CPython. MSVC CPython doesn't have any of the config vars that are required in customize_compiler() though. And while it would be nice if all the env vars would be considered in that scenario too, it's not clear how this should be implemented without any sysconfig provided fallbacks (if CC isn't set but CFLAGS is, there is no way to pass things to set_executables() etc.) Given that, just restore the previous behaviour, skip customize_compiler() with MSVC Python in all cases, and add a test. Fixes https://github.com/pypa/setuptools/issues/4456
|
(the first commit is a CI build fix, which was caused by setuptools on pypi now behaving differently) |
jaraco
added a commit
that referenced
this pull request
Jul 9, 2024
…thon sysconfig: skip customize_compiler() with MSVC Python again
|
Re-merged as e221581 (I forgot to make the pr reference project-absolute). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By enabling customize_compiler() when using the mingw compiler class
in 2ad8784 this also enabled it for when the mingw compiler
class was used with a MSVC built CPython.
MSVC CPython doesn't have any of the config vars that are required in
customize_compiler() though. And while it would be nice if all the env
vars would be considered in that scenario too, it's not clear how this
should be implemented without any sysconfig provided fallbacks
(if CC isn't set but CFLAGS is, there is no way to pass things to
set_executables() etc.)
Given that, just restore the previous behaviour, skip customize_compiler()
with MSVC Python in all cases, and add a test.
Fixes #268