Use a separate build directory for free-threading #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
jaraco
reviewed
Jun 26, 2024
Comment on lines
+28
to
+29
| if get_config_var('Py_GIL_DISABLED'): | ||
| plat_spec += 't' |
There was a problem hiding this comment.
I confirmed that by adding this test (without the fix), the tests now fail, and tests pass with the fix. Nice.
jaraco
approved these changes
Jun 26, 2024
|
I'm ignoring the diffcov failure - it only checks coverage on a single environment, so until we have a test suite that implements coverage across all supported environments and we have CI environments running with Python free-threading, these lines are going to be uncovered. |
|
Thank you for the quick review! |
jaraco
added a commit
that referenced
this pull request
Jun 28, 2024
Use a separate build directory for free-threading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I work on the drgn debugger, and with the recently added 3.13t builds in the manylinux docker, which enable the
--disable-giloption, we started getting some build failures when building wheels. It turned out that the standard and free-threading builds of 3.13 both use the samebuild_tempandbuild_libdirectories.Drgn has a bit of a customized build system which allows incremental builds within the
build_tempdirectory, so the object files from 3.13 were getting reused for the free-threaded build, but the ABI is not compatible anymore. The result was an extension that segfaulted immediately on import.It seems that a standard distutils extension doesn't have incremental build support, so maybe overlapping
build_tempandbuild_libdirectories isn't a huge problem. But looking through the code, it seems like distutils tries to avoid overlapping thesebuild_tempandbuild_libdirectories where the compiler could get confused or produce incorrect results. So I thought this might be a suitable fix for distutils itself, rather than just in drgn's build system.Thanks!