chore: TOML 1.0 support: drop toml, use tomli #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to get TOML 1.0 support, and lightens our dependencies a bit.
|
Looks good. Do we need to keep the support code in cibuildwheel.extra? Is that so it can be tested? |
|
Yes, that's why. We could move it into bin and just add the testing there too. We don't import from bin, so it would be one big file. But I don't mind that way either. |
joerick
approved these changes
Oct 14, 2021
|
All good, was just curious :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to get TOML 1.0 support, and lightens our dependencies a bit. I think most other packages have already switched (pip, etc). Manually writing the output file since tomli-w doesn't support formatting, and tomlkit doesn't keep the output structure as promised. This is probably simpler/easier for us.
Closes #534.