Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fallthrough empty manylinux images #829

Merged
merged 2 commits into from
Sep 17, 2021
Merged

fix: fallthrough empty manylinux images #829

merged 2 commits into from
Sep 17, 2021

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Sep 17, 2021 •
edited
Loading

Fixes #827. This was a regression in 2.0.

cibuildwheel/cibuildwheel/__main__.py

Lines 292 to 294 in da84127

config_value = os.environ.get(config_name)
if config_value is None:

joerick
joerick reviewed Sep 17, 2021
View reviewed changes
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henryiii , just a couple comments

cibuildwheel/options.py Outdated Show resolved Hide resolved
cibuildwheel/options.py Outdated Show resolved Hide resolved
@henryiii henryiii merged commit a665fb7 into pypa:main Sep 17, 2021
@henryiii henryiii deleted the henryiii/fix/manylinuxft branch September 17, 2021 19:52
@nitzmahone
Copy link
Contributor

Nice- just hit a need for this today and was about to submit a PR for it... Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerick joerick joerick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty MANYLINUX env variable produces invalid result
3 participants
@henryiii @nitzmahone @joerick