ci: warm-up docker images #2099
Conversation
|
That's roughly 4/5 minutes less in the GHA build on x86_64, doesn't change a thing on qemu builds except for aarch64 where it's slower (probably because graalpy also gets installed). |
|
How much slower? Seems like an overall win? |
|
It seems like an overall win, I will do a proper sum-up this week-end once a couple things are fixed like the emulation run on GHA. |
5f25a79 to
0552ca1
Compare
|
Here's a sum-up, with last commits:
|
test/conftest.py
Outdated
| if exit_code == "0": | ||
| subprocess.run( | ||
| ["docker", "commit", container_id, image], check=True, stdout=subprocess.DEVNULL | ||
| ) |
There was a problem hiding this comment.
Should we print an error or fail if the command doesn't succeed?
There was a problem hiding this comment.
Good point. should we print or fail ?
Maybe we should just fail here. I will add a commit doing that (& revert if we decide not to fail but print).
Let's see if we can speed-up linux CI by warming-up docker images.
This helps locally but I have a very slow Internet connection so it might not apply here.