Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test-sources configuration option. #2062
Add a test-sources configuration option. #2062
Changes from 5 commits
23d3ca2
beb8b9d
2622c12
12912b6
889329a
e17edc4
89f5ba6
2ca58f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't handle filenames/directories with a space in it. Should we care about such things? I suppose it can't really hurt! so... the solution here would be to add an optional
quote
param to ListFormat, use it here likeListFormat(sep=" ", quote=shlex.quote)
, and then useshlex.split()
rather thansplit()
here.I'm happy to make that change if the above isn't clear!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense - I'll add this to my todo list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just pushed an update that does shlex quote handling; not sure if there's any additional testing that you'd like to see - I couldn't find an obvious trove of explicit ListOption tests.
I'm still looking into the Pyodide test that failed on the previous CI run.
This file was deleted.
Check warning on line 411 in cibuildwheel/util.py
GitHub Actions / Linters (mypy, flake8, etc.)
W0621