Issue a purge request when we get a stale serial. #57
Conversation
81550eb to
a892bda
Compare
There was a problem hiding this comment.
Thanks for working on this!
I will accept once we get the logging (as I don’t run in debug in prod). When I merge I’ll open a Issue with warehouse and work with @dstufft + others to try and root cause and work to remove this.
src/bandersnatch/master.py
Outdated
| logger.warning( | ||
| "Got an error when attempting to clear the cache", exc_info=True | ||
| ) | ||
|
|
||
| raise StalePage( | ||
| "Expected PyPI serial {} for request {} but got {}".format( |
There was a problem hiding this comment.
Can we add to the exception message that we’ve sent a PURGE (more to remind me / other devs in the future)
There was a problem hiding this comment.
Yeah but iirc the stalepage exception is just swallowed, so the message isn't seen.
There was a problem hiding this comment.
It will if you have stop-on-error set in the config file.
97b1f84 to
4031009
Compare
|
Now PURGE is no more open but requiring credentials, so this HACK leads to 401 error flooding the log. Shall we consider removal of this workaround? see also: #1220 About the root cause, have a look at pypi/warehouse#12214 |
|
I did see this was removed, forgot about it. Naughty me should have cut an issue. I’d be more than happy to pull it out and release a new minor version. PR welcome. Will cleanup the code too and stop wasting peoples resources trying. |
#1334 there ya go! |
Temporary fix for #56. We issue a PURGE to the url if we get a stale serial. Not ideal, but a workaround until PyPI's caches are fixed to always return the up-to-date header.