Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PPC64le policy architecture #59

Closed
wants to merge 1 commit into from
Closed

Conversation

lbianc
Copy link

@lbianc lbianc commented Jan 6, 2017

In order to make auditwheel work in PPC64le machines, the policy.json file
and the way it is read were changed.

In order to make auditwheel work in PPC64le machines, the policy.json file
and the way it is read were changed.
@rmcgibbo
Copy link
Member

rmcgibbo commented Jan 6, 2017

This probably needs further discussion, as PEP513 currently states that manylinux1 is only defined for the x86_64 and i686 architectures.

@lbianc
Copy link
Author

lbianc commented Jan 6, 2017

I have created this PR, but I still have some questions regarding the json file:

What are "CXXABI", "GLIBCXX" and "GCC" used for? Is it necessary? I run some tests on my machine and it worked.
On "GLIBC" I have added the glibc version that was being used in my system, is it necessary to add any other?
I tried to run the tests, but it says that 0 tests run. How can I run it?

@lbianc
Copy link
Author

lbianc commented Jan 6, 2017

@rmcgibbo Hi. Yes, but what would be the blocks to use it on another architecture? The PPC64le is pretty new, and using the first port version should work, as worked. I have tested in SUSE, Fedora, Ubuntu and CentOS.
Where should I start this discussion?

@rmcgibbo
Copy link
Member

rmcgibbo commented Jan 6, 2017

https://mail.python.org/mailman/listinfo/wheel-builders is the appropriate mailing list.

@lbianc
Copy link
Author

lbianc commented Jan 6, 2017

Ok. I will start a thread there. Any beginner tip to start a PEP or just start the discussion to run it on another architecture?

@ehashman
Copy link
Member

Hello @lbianc!

What are "CXXABI", "GLIBCXX" and "GCC" used for? Is it necessary? I run some tests on my machine and it worked.

These are the names of all the symbol versions defined in all the libraries in the lib_whitelist section of the policy.

On "GLIBC" I have added the glibc version that was being used in my system, is it necessary to add any other?

Yes. You need to add every single symbol version that is defined in the libraries in the lib_whitelist in order to build the compatible policy. Right now, because only GLIBC version is defined, you will likely find that many wheels will fail auditwheel and your new policy.

The way I generated this for the manylinux1 x86_64/i686 policy from the docker image can be found here: #43 (comment)

@lbianc
Copy link
Author

lbianc commented May 25, 2017

@ehashman Currently I'm waiting the definition of manylinux_2 tag to add ppc64 information, so then develop the port. Thanks, it will be helpful.

@thewtex
Copy link

thewtex commented Mar 12, 2018

:xref: #88

@ehashman
Copy link
Member

Hi @lbianc,

Thanks for your hard work on this PR. Since there's a merge conflict and this has been stale for a while (and it looks like the manylinux2010 [nee manylinux2] changes will supersede this), I'm going to close this PR for now. Feel free to reopen it in the future if you get a chance to address the comments above!

@ehashman ehashman closed this May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants