Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -vv TRACE logging level #382

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

abitrolly
Copy link

To reduce the output of policy checker unless requested.

To reduce the output of policy checker unless requested
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.20%. Comparing base (55bc5ee) to head (fc0360c).
Report is 90 commits behind head on main.

Files with missing lines Patch % Lines
src/auditwheel/main.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   92.42%   91.20%   -1.23%     
==========================================
  Files          23       23              
  Lines        1267     1273       +6     
  Branches      311      292      -19     
==========================================
- Hits         1171     1161      -10     
- Misses         55       61       +6     
- Partials       41       51      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

To have some order in log messages
@abitrolly
Copy link
Author

TRACE level can probably be defined in the root __init__.py for convenience https://stackoverflow.com/questions/2183233/how-to-add-a-custom-loglevel-to-pythons-logging-facility/35804945#35804945

@abitrolly
Copy link
Author

The output from versioned_symbols_policy is overly verbose, because it is called several times and each time iterates over all JSON policies, from here.

policy_symbols[k].update(ext_symbols[k])
result.append((versioned_symbols_policy(policy_symbols), policy_symbols))
return result

In my case it is 64 times just for policy check without TRACE output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant