Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cbor-edn package to 1.1.0 #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chrysn
Copy link

@chrysn chrysn commented Jan 15, 2025

Description

This updates the cbor-edn package, which is used as part of aiocoap demos that use pyodide and Jupyter. The new version supports processing the full range of the notation as it is being updated, and brings readability enhancements by converting tagged data into application oriented literals.

Before: {1:54(h'20010db8000000000000000000000001'),3:1(1736861269)}

After: {1: IP'2001:db8::1', 3: DT'2025-01-14T13:27:49Z'}

The test is updated to cover some new functionality; as in the original version, it is by far not comprehensive, and mainly checks whether it's there and does something (but now that something includes features from the 1.1 series).

Context

Closes: pyodide/pyodide#5326

Filing this here after being redirected in pyodide/pyodide#5326 -- is there any change log to update, or is this auto-managed here?

@ryanking13
Copy link
Member

is there any change log to update, or is this auto-managed here?

We don't have a way to manage changelogs for this repository yet. I'll be writing code to calculate the diff between the old and new versions of the package list and update the list automatically, so I don't think you'll need to update the changelog yourself.

The explicitly requested version does not fit the requirements of the
package's dependencies any more, and is not necessary to build any more
anyway.
@chrysn
Copy link
Author

chrysn commented Jan 15, 2025

Building has run into trouble around an old proc-macro pinning in the package. I'm not sure that removing the script is fine, but let's see what CI says; the commit message is phrased on the assumption that it does (for if it does not, it won't get merged anyway).

@ryanking13
Copy link
Member

Thanks. I triggered the CI (for first-time contributors). Let's see if it works.

@chrysn
Copy link
Author

chrysn commented Jan 16, 2025

As I couldn't trace down precisely why CI failed, I ran a pip install pyodide_build / pyodide build-recipes cbor-diag, but couldn't get the precise emscripten version locally.

Is there an easy way to read the content of the build-reqs file which

ERROR Command '['/home/runner/miniconda3/envs/pyodide-env/bin/python', '-m',    
'pip', '--python', '/tmp/build-env-p2hkpgdr/bin/python', 'install',             
'--use-pep517', '--no-warn-script-location', '--no-compile', '-r',              
'/tmp/build-reqs-iukvkvg3.txt']' returned non-zero exit status 1.               
[2025-01-16 07:18:17] Failed building package cbor-diag in 14.0 seconds.

tripped over?

@ryanking13
Copy link
Member

build-reqs file will contains the build-system requirements in the pyproject.toml file.

We are currently pinning the maturin version < 1.8 becuase of the regression in maturin but it seems like cbor-diag uses maturin >= 1.8 which is causing the error I guess.

@chrysn
Copy link
Author

chrysn commented Jan 16, 2025

Thanks. Following the #87 approach would not have made a difference with the old cbor-diag version (pyodide/pyodide#5283), but current cbor-diag already sets dynamic = ["version"], so it should not need the blocker now.

I'll keep an eye out for pyodide/pyodide#5283 and #87, and if either makes progress, I can rebase this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants