gdbserver: fix some error responses #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't return the detach value, which was removed in 17ab710. This fixes one of the issues reported in pyocd#1409.
- .handle_query_xml() returns the correct empty packet or error instead of raising GDBError. - .get_symbol() logs the error and returns None to the caller.
- Restructure code to always call into .handle_query_xml() for qXfer read commands. - Return empty packet on unknown qXfer operation. - Pass annex to .handle_query_xml(). - Explicit check for read features annex being 'target.xml', and that the annex is empty for other objects.
flit
added a commit
to flit/pyOCD
that referenced
this pull request
Jun 26, 2022
* gdbserver: correct return type from ._handle_message() on exceptions Don't return the detach value, which was removed in 17ab710. This fixes one of the issues reported in pyocd#1409. * gdbserver: replace GDBError exceptions with logs - .handle_query_xml() returns the correct empty packet or error instead of raising GDBError. - .get_symbol() logs the error and returns None to the caller. * gdbserver: qXfer command fixes - Restructure code to always call into .handle_query_xml() for qXfer read commands. - Return empty packet on unknown qXfer operation. - Pass annex to .handle_query_xml(). - Explicit check for read features annex being 'target.xml', and that the annex is empty for other objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDBErrorexception class with error logs and appropriate response packets (if any).GDBServer.get_symbol()logs the error and returns None to the caller.qXfercommand handling. The annex value is checked, and some incorrect error responses are fixed.