setup: make pyocd-pemicro optional #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only difference is that prettytable 3.x dropped Python 3.6 support. We still allow version 2.x for 3.6.
|
Fixes #1314 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to move
pyocd-pemicroto an optional extra install. There are two reasons for this:The PEMicro shared libraries contained in the
pypemicroPython package are closed source. That's an issue for a number of Linux distros. (The built-in Segger J-Link probe driver also uses a closed source shared library at runtime, but that library is not contained in or installed via a Python package.)For some reason, the PEMicro shared libraries cause Microsoft PowerShell to crash when pyocd exits. See Use of pyocd to flash from powershell seems to emit an error #1129.
Making
pyocd-pemicroan install extra means that installing it is as simplepip install pyocd[pemicro]. Installation documentation has been updated to note this, and a section added to the debug probes documentation.Other included changes: allow prettytable version 3.x; fix the keywords metadata value.
cc @Gargy007 @dvzrv
Fixes #1319