Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert numpy warnings workaround #6025

Merged

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Aug 3, 2022

This workaround was originally written for Aesara in aesara-devs/aesara#980 to suppress spurious warnings when Aesara loads Numpy under Windows. It was subsequently ported to run here on pymc in #5956. It has been subsequently fixed upstream in Aesara in a superior way by aesara-devs/aesara#1050. Therefore, this workaround is obsolete, so I'm reverting it.

What is this PR about?
...

Checklist

Major / Breaking Changes

  • None (hopefully!)

Bugfixes / New features

  • None

Docs / Maintenance

  • Cleans up unnecessary code 🚀

Tests:

AFAIK there's no test here for warnings. But there is on Conda-Forge, so any problems on a release would be caught very quickly.

maresb added 2 commits August 3, 2022 23:41
This reverts commit 294ff4a.
This has been fixed upstream in Aesara and is therefore no longer necessary.
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #6025 (08b1079) into main (9f93b3e) will increase coverage by 3.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6025      +/-   ##
==========================================
+ Coverage   86.28%   89.28%   +3.00%     
==========================================
  Files          72       72              
  Lines       12905    12884      -21     
==========================================
+ Hits        11135    11504     +369     
+ Misses       1770     1380     -390     
Impacted Files Coverage Δ
pymc/__init__.py 100.00% <ø> (+31.57%) ⬆️
pymc/step_methods/hmc/base_hmc.py 89.76% <0.00%> (-0.79%) ⬇️
pymc/model.py 88.20% <0.00%> (+0.13%) ⬆️
pymc/backends/base.py 86.44% <0.00%> (+0.73%) ⬆️
pymc/step_methods/slicer.py 96.20% <0.00%> (+1.26%) ⬆️
pymc/backends/report.py 91.04% <0.00%> (+4.47%) ⬆️
pymc/step_methods/arraystep.py 94.32% <0.00%> (+7.80%) ⬆️
pymc/data.py 80.08% <0.00%> (+12.19%) ⬆️
pymc/sampling.py 82.48% <0.00%> (+12.33%) ⬆️
pymc/step_methods/metropolis.py 83.36% <0.00%> (+43.65%) ⬆️

@maresb maresb marked this pull request as ready for review August 4, 2022 07:34
@maresb
Copy link
Contributor Author

maresb commented Aug 4, 2022

Ping @michaelosthege since he coauthored the commit I'm reverting.

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you confirmed with a recent version that the import is now indeed silent?

My environment are not on the latest version yet..

@maresb
Copy link
Contributor Author

maresb commented Aug 4, 2022

Not really, that would require a Windows machine.

It's tested fairly thoroughly at the level of the Aesara feedstock on Conda-Forge. Although there is a very slight possibility that PyMC does some funny import order and breaks the Aesara fix somehow.

If you want, I think I could rig up a draft PR on the PyMC feedstock and redirect it to this branch in order to verify it on one of the Conda-Forge Windows VMs. (I can't do that right away though.)

@michaelosthege michaelosthege merged commit b506fec into pymc-devs:main Aug 4, 2022
@maresb maresb deleted the revert-numpy-warnings-workaround branch August 4, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants