Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #6013

Closed
twiecki opened this issue Jul 26, 2022 · 8 comments · Fixed by #6014
Closed

Drop support for Python 3.7 #6013

twiecki opened this issue Jul 26, 2022 · 8 comments · Fixed by #6014

Comments

@twiecki
Copy link
Member

twiecki commented Jul 26, 2022

#6010 added support for Python 3.7 temporarily to get it working on colab. As we have a release that supports this now, we should drop it again.

@michaelosthege
Copy link
Member

michaelosthege commented Jul 27, 2022

@canyon289 I'm getting some import errors with PyMC 4.1.4 and under Python 3.7 in thie CI pipeline run: https://github.com/michaelosthege/mcbackend/runs/7531219139?check_suite_focus=true

The install in this CI pipeline uses pip.

mcbackend/test_adapter_pymc.py:6: in <module>
    import pymc as pm
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/pymc/__init__.py:119: in <module>
    __set_compiler_flags()
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/pymc/__init__.py:100: in __set_compiler_flags
    import aesara
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/aesara/__init__.py:64: in <module>
    from aesara.configdefaults import config
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/aesara/configdefaults.py:11: in <module>
    from setuptools._distutils.spawn import find_executable
E   ModuleNotFoundError: No module named 'setuptools._distutils'

@canyon289
Copy link
Member

@canyon289 I'm getting some import errors with PyMC 4.1.4 and under Python 3.7 in thie CI pipeline run: https://github.com/michaelosthege/mcbackend/runs/7531219139?check_suite_focus=true

The install in this CI pipeline uses pip.

mcbackend/test_adapter_pymc.py:6: in <module>
    import pymc as pm
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/pymc/__init__.py:119: in <module>
    __set_compiler_flags()
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/pymc/__init__.py:100: in __set_compiler_flags
    import aesara
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/aesara/__init__.py:64: in <module>
    from aesara.configdefaults import config
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/aesara/configdefaults.py:11: in <module>
    from setuptools._distutils.spawn import find_executable
E   ModuleNotFoundError: No module named 'setuptools._distutils'

Trying it again here, though I'm not sure what the error is. Ive been ad hoc testing in colab and things have worked fine there
#6016

image

@michaelosthege
Copy link
Member

michaelosthege commented Jul 27, 2022

Looks like the setuptools minimum version specified in v2.7.8 / aesara-devs/aesara#1050 was not enough. Or even a problem with lower-level dependencies: https://stackoverflow.com/questions/63683262/modulenotfounderror-no-module-named-setuptools-distutils

@maresb could this be something that needs a fix in the Aesara feedstock?

@maresb
Copy link
Contributor

maresb commented Jul 27, 2022

Ya, it does appear at first glance to be an issue with the minimum version of setuptools. Could someone report a particular version of setuptools which is problematic?

@maresb
Copy link
Contributor

maresb commented Jul 27, 2022

Looks like a typo, the pin should be setuptools >=48.0.0 but it's currently setuptools >=45.0.0. @brandonwillard?

@maresb
Copy link
Contributor

maresb commented Jul 27, 2022

Sorry, I should have shown my work...

Look at the history of the _distutils folder, which originates at this commit. Looking at the tags at the top, it came into the v48.0.0 release. And indeed comparing that release with the previous version confirms this is when it was included.

As for what to do about it, we should probably fix it for the next release. We could also issue a repodata patch to retroactively fix affected versions on Conda-Forge.

@maresb
Copy link
Contributor

maresb commented Aug 5, 2022

Sorry I didn't follow up sooner... We should also raise this issue in Aesara and fix the version pin and patch the CF repodata there, no? Or has someone taken care of it already?

@maresb
Copy link
Contributor

maresb commented Aug 5, 2022

Upstream fixes have been submitted in aesara-devs/aesara#1100 and conda-forge/conda-forge-repodata-patches-feedstock#307.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants