Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transforming adaptation #27

Merged
merged 8 commits into from
Oct 23, 2024
Merged

Add transforming adaptation #27

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a75921b
feat: Make cpu_math parallelization configurable
aseyboldt Sep 26, 2024
05b78cf
chore: Update dependencies
aseyboldt Sep 26, 2024
0f246f2
More transform refactoring
aseyboldt Oct 11, 2024
1752c63
feat: Add transforming adaptation
aseyboldt Oct 17, 2024
fb63fb1
refactor: Refactor mass matrix adaptation traits
aseyboldt Oct 17, 2024
88f22a0
feat: Improve error info for BadInitGrad
aseyboldt Oct 23, 2024
bc36d05
feat: Do not report invalid gradients for transform adapt
aseyboldt Oct 23, 2024
5c92d46
chore: Prepare release
aseyboldt Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: Do not report invalid gradients for transform adapt
@aseyboldt
aseyboldt committed Oct 23, 2024
commit bc36d05d3e8d2c44bb13a633eaea1343c3ba50fa
12 changes: 12 additions & 0 deletions src/transform_adapt_strategy.rs
View file
Original file line number Diff line number Diff line change
@@ -114,6 +114,12 @@ impl<M: Math, P: Point<M>> Collector<M, P> for DrawCollector<M> {
let point = end.point();
let energy_error = point.energy_error();
if energy_error.abs() < self.max_energy_error {
if !math.array_all_finite(point.position()) {
return;
}
if !math.array_all_finite(point.gradient()) {
return;
}
self.draws.push(math.copy_array(point.position()));
self.grads.push(math.copy_array(point.gradient()));
}
@@ -125,6 +131,12 @@ impl<M: Math, P: Point<M>> Collector<M, P> for DrawCollector<M> {
let point = state.point();
let energy_error = point.energy_error();
if energy_error.abs() < self.max_energy_error {
if !math.array_all_finite(point.position()) {
return;
}
if !math.array_all_finite(point.gradient()) {
return;
}
self.draws.push(math.copy_array(point.position()));
self.grads.push(math.copy_array(point.gradient()));
}