Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make_initial_point_fn #61

Merged
merged 4 commits into from
Sep 12, 2023
Merged

fix make_initial_point_fn #61

merged 4 commits into from
Sep 12, 2023

Conversation

ferrine
Copy link
Member

@ferrine ferrine commented Sep 4, 2023

fix #60

pyproject.toml Outdated
all = [
"bridgestan >= 2.1.2",
"pymc >= 5.5.0",
"pymc >= 5.8.0",
Copy link
Member

@ricardoV94 ricardoV94 Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed. The new path is the correct one for the older versions of pymc as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted any changes to pymc versions

@ferrine ferrine force-pushed the make_initial_point_fn branch from 3030a24 to 8c6aecd Compare September 5, 2023 11:41
@ricardoV94
Copy link
Member

Is this ready @ferrine?

Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com>
@twiecki
Copy link
Member

twiecki commented Sep 11, 2023

@ricardoV94
Copy link
Member

ricardoV94 commented Sep 11, 2023

https://github.com/pymc-devs/nutpie/blob/main/CHANGELOG.md

That's very cumbersome compared to automatic release notes (and I don't think it's been properly updated)

@twiecki
Copy link
Member

twiecki commented Sep 11, 2023

@ricardoV94 then we can just merge

@twiecki twiecki merged commit 182cf67 into main Sep 12, 2023
@twiecki twiecki deleted the make_initial_point_fn branch September 12, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After pymc update there is an issue with model compilation
3 participants