-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positive for arguments-differ
#8927
Conversation
The issue isn't connected to subclassing |
bab248d
to
1ed5665
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1ed5665
to
75dcb6b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8927 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 173 173
Lines 18557 18557
=======================================
Hits 17767 17767
Misses 790 790
|
Something not right with the CI. The failing pypy test is the same one that was failing for 3.8/3.9/3.10 etc. before pulling the main branch. Not sure what that is - pytest cache of results stored in our cache between branch updates? π€ |
This comment has been minimized.
This comment has been minimized.
β¦ubclass__`. Closes pylint-dev#8919
75dcb6b
to
595b1a3
Compare
π€ Effect of this PR on checked open source code: π€ Effect on pytest:
Effect on django:
This comment was generated for commit 595b1a3 |
Type of Changes
Description
Fix false positive for
arguments-differ
when overriding__init_subclass__
.Closes #8919