Rename unneeded-not to unnecessary-negation for clarity
#8846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
β¦o fix-unneeded-not
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8846 +/- ##
==========================================
- Coverage 95.88% 95.74% -0.14%
==========================================
Files 173 173
Lines 18548 18557 +9
==========================================
- Hits 17785 17768 -17
- Misses 763 789 +26
|
This comment has been minimized.
This comment has been minimized.
.gitignore
Outdated
| @@ -4,6 +4,7 @@ | |||
| /log | |||
| *.py[cod] | |||
| /build | |||
| /venv | |||
There was a problem hiding this comment.
You can use a global gitignore for that :)
| """This is also ok""" | ||
| def __ne__(self, other): | ||
| return not self == other | ||
| """Check exceeding negations in boolean expressions trigger warnings""" |
There was a problem hiding this comment.
It's strange that everything changed here, probably due to modified end of line (\r\n vs \n). Could you revert to the original line ending ? It preservs the git blame and we need some diversity in line ending in some of the tests which is why it's not uniformized with a .gitattributes :)
added 2 commits
July 19, 2023 13:36
This comment has been minimized.
This comment has been minimized.
unneeded-not to unnecessary-negation for clarity
|
Thanks for the contribution @gracejiang16! |
jacobtylerwalls
approved these changes
Aug 6, 2023
Pierre-Sassoulas
requested changes
Aug 6, 2023
| @@ -0,0 +1,3 @@ | |||
| Renamed the "unneeded-not" error into "unnecessary_negation" to be clearer. | |||
There was a problem hiding this comment.
Suggested change
| Renamed the "unneeded-not" error into "unnecessary_negation" to be clearer. | |
| Renamed the "unneeded-not" error into "unnecessary-negation" because it can be raised on comparators too (in a context where the `not` keyword is not used). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename 'unneeded-not' to 'unnecessary-negation.' Deprecate old name.
Type of Changes
Description
Closes #8789