Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for #1667 #7113

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Add regression test for #1667 #7113

merged 4 commits into from
Jul 18, 2022

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #1667
Depends on astroid 2.12 (not one of the patch versions)

@jacobtylerwalls jacobtylerwalls added Crash 💥 A bug that makes pylint crash Needs astroid update Needs an astroid update (probably a release too) before being mergable labels Jul 2, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.15.0 milestone Jul 2, 2022
@jacobtylerwalls jacobtylerwalls mentioned this pull request Jul 13, 2022
Open
@jacobtylerwalls jacobtylerwalls marked this pull request as ready for review July 17, 2022 21:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2687015659

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.246%
Totals Coverage Status
Change from base Build 2686707315: 0.0%
Covered Lines: 16808
Relevant Lines: 17647
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That test with tempdir / create_files is pretty straightforward. It's very easy to create "complicated" example without resorting to an input/data/regr_test_data directory. (I.e. PR is so clean it makes me want to refactor 30% of the tests 😄 )

@Pierre-Sassoulas Pierre-Sassoulas merged commit ff3f91d into pylint-dev:main Jul 18, 2022
@jacobtylerwalls jacobtylerwalls deleted the issue-1667 branch July 18, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Crash 💥 A bug that makes pylint crash Needs astroid update Needs an astroid update (probably a release too) before being mergable
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

ImportError when using PEP 420 namespaces
3 participants
@jacobtylerwalls @coveralls @Pierre-Sassoulas