-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable test_crypt_brain on Python >= 3.13 #2328
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2328 +/- ##
==========================================
- Coverage 92.86% 92.76% -0.10%
==========================================
Files 94 94
Lines 11065 11066 +1
==========================================
- Hits 10275 10265 -10
- Misses 790 801 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a constant like:
Line 12 in d3e8a9f
PY312_PLUS = sys.version_info >= (3, 12) |
And using that?
Will do, update incoming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We'll definitely need to fix the other tests as well, but I think it's more likely that will happen when 3.13
is a little bit more stable.
Thank you! I may take a look at those if I have time. I may not. :) |
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com> (cherry picked from commit acfb755)
Thanks @limburgher, always appreciated when downstream packagers bring fixes to upstream! |
Resolves #2327 but leaves two failures remaining:
FAILED tests/test_inference.py::test_dataclasses_subscript_inference_recursion_error_39
FAILED tests/brain/test_brain.py::TypingBrain::test_typing_annotated_subscriptable