Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test_crypt_brain on Python >= 3.13 #2328

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Disable test_crypt_brain on Python >= 3.13 #2328

merged 6 commits into from
Oct 25, 2023

Conversation

limburgher
Copy link
Contributor

Resolves #2327 but leaves two failures remaining:

FAILED tests/test_inference.py::test_dataclasses_subscript_inference_recursion_error_39
FAILED tests/brain/test_brain.py::TypingBrain::test_typing_annotated_subscriptable

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2328 (6d5b43c) into main (7124000) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2328      +/-   ##
==========================================
- Coverage   92.86%   92.76%   -0.10%     
==========================================
  Files          94       94              
  Lines       11065    11066       +1     
==========================================
- Hits        10275    10265      -10     
- Misses        790      801      +11     
Flag Coverage Δ
linux 92.67% <100.00%> (+<0.01%) ⬆️
pypy ?
windows 92.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
astroid/const.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a constant like:

PY312_PLUS = sys.version_info >= (3, 12)

And using that?

@limburgher
Copy link
Contributor Author

Would you mind adding a constant like:

PY312_PLUS = sys.version_info >= (3, 12)

And using that?

Will do, update incoming.

Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll definitely need to fix the other tests as well, but I think it's more likely that will happen when 3.13 is a little bit more stable.

@DanielNoord DanielNoord added this to the 3.0.2 milestone Oct 25, 2023
@DanielNoord DanielNoord enabled auto-merge (squash) October 25, 2023 21:36
@limburgher
Copy link
Contributor Author

Thank you! I may take a look at those if I have time. I may not. :)

@DanielNoord DanielNoord merged commit acfb755 into pylint-dev:main Oct 25, 2023
github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
(cherry picked from commit acfb755)
Pierre-Sassoulas pushed a commit that referenced this pull request Oct 26, 2023
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
(cherry picked from commit acfb755)

Co-authored-by: Gwyn Ciesla <gwync@protonmail.com>
@DanielNoord
Copy link
Collaborator

Thanks @limburgher, always appreciated when downstream packagers bring fixes to upstream!

@Pierre-Sassoulas Pierre-Sassoulas added backported Assigned once the backport is done and removed backport maintenance/3.3.x labels Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Assigned once the backport is done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

astroid depends on 'crypt', which is removed in Python 3.13
3 participants