Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport maintenance/2.15.x] Make sys.argv uninferable because it never is (#2244) #2297

Conversation

jacobtylerwalls
Copy link
Member

Backport of #2244

It's impossible to infer the value it will have outside of static analysis where it's our own value.

See pylint-dev/pylint#7710

(cherry picked from commit ea78827)
@jacobtylerwalls jacobtylerwalls added this to the 2.15.7 milestone Sep 23, 2023
@jacobtylerwalls jacobtylerwalls changed the title [backport maintenance/2.15.x] Make sys.argv uninferable because it never is (#2244) [Backport maintenance/2.15.x] Make sys.argv uninferable because it never is (#2244) Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #2297 (7346e9e) into maintenance/2.15.x (554d93e) will increase coverage by 0.10%.
Report is 8 commits behind head on maintenance/2.15.x.
The diff coverage is 96.55%.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           maintenance/2.15.x    #2297      +/-   ##
======================================================
+ Coverage               92.84%   92.95%   +0.10%     
======================================================
  Files                      95       95              
  Lines                   11089    11106      +17     
======================================================
+ Hits                    10296    10324      +28     
+ Misses                    793      782      -11     
Flag Coverage Δ
linux 92.67% <96.55%> (+0.11%) ⬆️
pypy 88.09% <96.55%> (+0.08%) ⬆️
windows 92.51% <96.55%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
astroid/manager.py 89.95% <91.66%> (+1.74%) ⬆️
astroid/__pkginfo__.py 100.00% <100.00%> (ø)
astroid/brain/brain_functools.py 98.70% <100.00%> (+0.03%) ⬆️
astroid/brain/brain_typing.py 88.43% <100.00%> (ø)
astroid/inference.py 94.60% <100.00%> (+0.01%) ⬆️
astroid/modutils.py 89.43% <100.00%> (+2.11%) ⬆️
astroid/protocols.py 90.72% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

@jacobtylerwalls jacobtylerwalls merged commit 0e0dd9c into pylint-dev:maintenance/2.15.x Sep 23, 2023
@jacobtylerwalls jacobtylerwalls deleted the backport-2244-to-maintenance/2.15.x branch September 23, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants