-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] select_rows
function implementation
#1173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…devs/pyjanitor into samukweku/select_rows
…devs/pyjanitor into samukweku/select_rows
🚀 Deployed on https://deploy-preview-1173--pyjanitor.netlify.app |
Codecov Report
@@ Coverage Diff @@
## dev #1173 +/- ##
==========================================
+ Coverage 97.93% 98.01% +0.07%
==========================================
Files 76 76
Lines 3387 3472 +85
==========================================
+ Hits 3317 3403 +86
+ Misses 70 69 -1 |
select_rows
function implementedselect_rows
function implementation
ericmjl
approved these changes
Oct 15, 2022
…o samukweku/select_rows
@samukweku how do you feel about the PR? It's been a while, but looks like it might be good to merge. |
@ericmjl yea, lets merge |
…devs/pyjanitor into samukweku/select_rows
Okie dokes, @samukweku! I think we should be good to merge here, is that right? |
Yes, good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
select_columns
level
argument dropped in favour of dictionary for more flexibility. No deprecation cycle required.._select_columns
and_select_rows
return a slice/booleans/integer/array of integers (via get_loc or get_locs) - this offers slightly better performance, instead of the initial round tripping, where the numeric indexer is obtained, the labels extracted, and then passed to loc. Now, we just pass the indexers to iloc, since we know exactly where the target label is.pivot_longer
andpivot_wider
.pd.get_locs
under the hood.loc
performance, since there is very little indirections/checks.This PR relates to #1124 .
MultiIndex selection with a dictionary - The example below is based on Pandas' Advanced Indexing guide:
You can also select partially on a MultiIndex with tuples - just like with
loc
, and select multiple tuples :PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.md
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.