Fix GitHub workflow CI #438
Conversation
Issues detected by flake8: 4 E275 missing whitespace after keyword 1 E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` 6 F401 'random' imported but unused 5 F841 local variable 'biv2' is assigned to but never used
* scipy.e is deprecated, use numpy.e instead see scipy/scipy@6e207a1 * Migrate to the latest github actions * Replace the unsupported python 3.5 with 3.8 * Use python 3.11 instead of 3.8, and 3.12 instead of 3.9
| @@ -14,12 +14,12 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python-version: [3.8] | |||
| python-version: [3.11] | |||
There was a problem hiding this comment.
| python-version: [3.11] | |
| python-version: ["3.11"] |
There was a problem hiding this comment.
(and throughout; otherwise when we eventually reach 3.20, yaml will parse it as 3.2!)
There was a problem hiding this comment.
That's true, 3.20 is the same as 3.2, i.e. must use "3.20".
BTW, this is valid for "3.10" also - I skipped it, but it could soon become the "legacy" version.
So, quotes are mandatory for versions that ends in zeros, otherwise - recommended. I suggest quoting all the versions. Is this ok?
Remove leftovers from python 2 compatibility Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 71.35% 67.28% -4.08%
==========================================
Files 73 74 +1
Lines 9461 9460 -1
Branches 1313 1212 -101
==========================================
- Hits 6751 6365 -386
- Misses 2539 2916 +377
- Partials 171 179 +8 ☔ View full report in Codecov by Sentry. |
Currently, CI fails because of following reasons:
scipy.e, which is no longer present (see scipy/scipy@6e207a1)This change also avoids some warnings about outdated GitHub actions versions.