Non-commutative inner product support

[trundev]

Add separate MultiVector.__ror__ (based on __or__), to calculate inner product from swapped operands.
The inner product is NOT a commutative operation.\

Fixes #426

[eric-wieser]

This looks good to me; can you add a test?

[trundev]

I added a TestBasicAlgebra.test_swapped_operands() (test/test_clifford.py).
It uses the MVArray <op> MultiVector trick to force use of MultiVector.__r<op>__. Covers multiple swapped operand operations, like __radd__, __rsub__, ... __ror__.

Possibly, this is a little bit of overshoot, please comment.

[trundev]

Hi @arsenovic,
After the CI is now fixed, this should be easier to merge this - it should pass all the CI pytest-s (if merged to latest master).
Sorry for the inconvenience!

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.13%. Comparing base (1102eba) to head (568087f).
Report is 18 commits behind head on master.

Files with missing lines	Patch %	Lines
clifford/_multivector.py	77.77%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
- Coverage   71.35%   71.13%   -0.23%     
==========================================
  Files          73       74       +1     
  Lines        9461     9437      -24     
  Branches     1313     1211     -102     
==========================================
- Hits         6751     6713      -38     
- Misses       2539     2551      +12     
- Partials      171      173       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eric-wieser]

Probably it's sufficient to just test g3 here, assuming that elements with non-commutative inner products exist there.

[eric-wieser]

Similarly, I'd be tempted to just pick two elements here on which all the products are non-commutative.

[trundev]

Is that ok: trundev@b2418f0

I did not push this in fix-pygae-426 branch to avoid history pollution (if something is not ok, it can be simply amended).

BTW, there is still no test coverage for the second return inside __ror__ (similar in __or__): https://github.com/trundev/clifford/blob/dcaa727/clifford/_multivector.py#L233
I'm not sure what cases it is intended to handle. Scalar multiplication is handled as if it is a multi-vector (converted by _checkOther).

[trundev]

@eric-wieser, please note that the "Simplify swapped operand operations pytest" commit was NOT included here.
I can create another PR, if something like it is preferred.

[eric-wieser]

If you've already written the code, please do!