support times with more than 24 hours #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example:
'27:17:54' cannot be represented by datetime.time.
Fallback to datetime.timedelta in this case.
|
Thanks for your patch. I will merge them. Could you please name one use case that needs this patch? |
chfw
added a commit
that referenced
this pull request
Jan 11, 2016
credits go to @bwaldvogel, support times with more than 24 hours
|
Use case: A duration that is formatted with HH:MM:SS |
|
Is there a release planned that will contain this improvement? |
|
I am sorry. I should have put a note here and in the release note. Yes, it is released together with 0.1.0. You should be able to get it via pypi now. |
|
Thanks. Works like a charm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
27:17:54cannot be represented bydatetime.time.Fallback to
datetime.timedeltain this case.