Add 403 Forbidden to STANDARD_ERRORS #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't actually an error the Eve Framework will ever raise. As far as I could tell. However, separation between authentication and authorization is a must even for less complex applicatons. 403 is the most adequate response a server can provide to client whose authentication was accepted, yet for some reason or another the server will not comply with the request. The Eve Framework documentation suggests the usage of 403 in, at least two instances: * `abort(403)` in: https://docs.python-eve.org/en/stable/features.html#database-event-hooks * The actual documentation for the `STANDARD_ERRORS` config variable, describes 403 as a supported code, in: https://docs.python-eve.org/en/stable/config.html#global-configuration
pedro2555
commented
Mar 1, 2020
There was a problem hiding this comment.
one other possible change is to actually include all error codes defined in RFC7231 section 6.1 or the official registry https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't actually an error the Eve Framework will ever raise. As far
as I could tell.
However, separation between authentication and authorization is a must
even for less complex applicatons. 403 is the most adequate response a
server can provide to client whose authentication was accepted, yet for
some reason or another the server will not comply with the request.
The Eve Framework documentation suggests the usage of 403 in, at least
two instances:
abort(403)in: https://docs.python-eve.org/en/stable/features.html#database-event-hooksSTANDARD_ERRORSconfig variable,describes 403 as a supported code, in: https://docs.python-eve.org/en/stable/config.html#global-configuration