Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use **mongo_options in with_options #1413

Closed
ehiggs opened this issue Sep 21, 2020 · 2 comments
Closed

Use **mongo_options in with_options #1413

ehiggs opened this issue Sep 21, 2020 · 2 comments
Milestone
1.1.4

Comments

@ehiggs
Copy link
Contributor

ehiggs commented Sep 21, 2020

#1411 introduced a fix where mongo_options could be passed in to be later passed to with_options. This should use **mongo_options and have unit tests that actually show the correct usage.
@nicolaiarocci nicolaiarocci modified the milestones: 1.1.1, 1.1.4 Sep 21, 2020
@ehiggs
Copy link
Contributor Author

ehiggs commented Sep 24, 2020

#1414 addresses this.

nicolaiarocci added a commit that referenced this issue Oct 22, 2020
@nicolaiarocci
changelog for #1413
cc0c3c3
@nicolaiarocci
Copy link
Member

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.4
Development

No branches or pull requests
2 participants
@ehiggs @nicolaiarocci