Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explained what a deprecation cycle is #5289
Explained what a deprecation cycle is #5289
Changes from 6 commits
445a575
bdf507f
a9db406
ddf8034
c903ba8
77cfc8e
7384608
76f1696
67f0951
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we also specify the warning? I'd say
DeprecationWarning
, but the docs are not really clear on this: it says the target audience forFutureWarning
is the users of an application, which I assume is not what we want.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've synthesized the difference as
FutureWarning
is for behavior changes, andDeprecationWarning
is for removal. I'm still not confident that's exactly right!But
DeprecationWarning
is right here I thinkThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to the docs (immediately below the table), that was the case before
python=3.7
. I don't think that explanation of the difference is particularly easy to understand, though.Since
xarray
is not a application, should we always useDeprecationWarning
?