Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: make copy of dask_gufunc_kwargs before changing content #4576

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Fix: make copy of dask_gufunc_kwargs before changing content #4576

merged 3 commits into from
Nov 12, 2020

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer kmuehlbauer commented Nov 12, 2020 •
edited
Loading

@kmuehlbauer kmuehlbauer mentioned this pull request Nov 12, 2020
Closed
max-sixty
max-sixty approved these changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmuehlbauer ! This LGTM.

I'll let someone who knows this function better comment if they want, and merge tomorrow.

Feel free to add a whatsnew

kmuehlbauer
kmuehlbauer commented Nov 12, 2020
View reviewed changes
@huard huard mentioned this pull request Nov 12, 2020
Merged
@max-sixty
Copy link
Collaborator

Great, thanks @kmuehlbauer !

@max-sixty max-sixty merged commit b76a13f into pydata:master Nov 12, 2020
@kmuehlbauer kmuehlbauer deleted the fix-output_sizes branch May 25, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

@keewis keewis keewis left review comments

@mathause mathause mathause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmuehlbauer @max-sixty @mathause @keewis