Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: Use len rather than size #1157

Merged
merged 1 commit into from
Dec 9, 2016
Merged

PERF: Use len rather than size #1157

merged 1 commit into from
Dec 9, 2016

Conversation

max-sixty
Copy link
Collaborator

Potential mitigation for pandas-dev/pandas#14822

shoyer
shoyer approved these changes Dec 8, 2016
View reviewed changes
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@max-sixty
Copy link
Collaborator Author

Are there any other places where we're looking at .size and know we're 1D?

@shoyer in general, would you like to merge these or is LGTM approval enough?

@shoyer
Copy link
Member

shoyer commented Dec 9, 2016

@MaximilianR you are welcome to merge these after an approval

@max-sixty max-sixty merged commit 1615a0f into pydata:master Dec 9, 2016
@max-sixty max-sixty deleted the perf-pindex branch December 9, 2016 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-sixty @shoyer