Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tox for cross Python-version testing #77

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Conversation

nils-werner
Copy link
Contributor

Note that the way Travis CI and py.test run their tests remain unchanged:

  • Travis CI runs multiple Python version tests in seprarate images
  • py.test works exactly as before

The only difference: Users can run tox on their local machines to test Python 2 and 3.

@hameerabbasi
Copy link
Collaborator

Can you also move the py.test options from setup.cfg to pytest.ini, since it's deprecated in 3.x? (I can't find a link in the docs, but see pytest-dev/pytest#3086)

@nils-werner
Copy link
Contributor Author

nils-werner commented Jan 15, 2018

The way I understood it was [pytest] was deprecated in favor of [tool:pytest], because the values from [whatever] where picked up when you run python setup.py whatever

@hameerabbasi
Copy link
Collaborator

Ah, in that case... We should be good.

@hameerabbasi hameerabbasi merged commit 013dbd1 into pydata:master Jan 15, 2018
@nils-werner
Copy link
Contributor Author

nils-werner commented Jan 15, 2018

Related to this issue and #71 it seems that NumPy<=1.12.0 has some issues that are not present in NumPy latest. It may make sense to test for multiple Python versions and multiple NumPy versions:

[tox]
envlist = {py27,py36}-{numpy12,numpylatest}
[testenv]
deps =
   numpy12: numpy==1.12.0
basepython =
   py27: python2.7
   py36: python3.6
commands=
   pip list
   py.test {posargs}
extras=
   docs
   tests

hameerabbasi pushed a commit to hameerabbasi/sparse that referenced this pull request Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants