Fixing header height (#1102)

pydata · Jan 7, 2023 · c0481b5 · c0481b5
1 parent 3309212
commit c0481b5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/src/pydata_sphinx_theme/assets/styles/base/_base.scss b/src/pydata_sphinx_theme/assets/styles/base/_base.scss
@@ -1,6 +1,6 @@
 html {
   font-size: var(--pst-font-size-base);
-  scroll-padding-top: calc(var(--pst-header-height) + 12px);
+  scroll-padding-top: calc(var(--pst-header-height) + 1rem);
 }
 
 body {

diff --git a/src/pydata_sphinx_theme/assets/styles/components/header/_header-logo.scss b/src/pydata_sphinx_theme/assets/styles/components/header/_header-logo.scss
@@ -1,8 +1,9 @@
 .navbar-brand {
   position: relative;
   height: var(--pst-header-height);
+  max-height: var(--pst-header-height);
+  padding: 0.5rem 0;
   width: auto;
-  padding: 0;
   margin: 0;
   display: flex;
   align-items: center;

diff --git a/src/pydata_sphinx_theme/assets/styles/sections/_header.scss b/src/pydata_sphinx_theme/assets/styles/sections/_header.scss
@@ -13,7 +13,8 @@
   background: var(--pst-color-on-background) !important;
   box-shadow: 0 0.125rem 0.25rem 0 var(--pst-color-shadow);
 
-  min-height: var(--pst-header-height);
+  height: var(--pst-header-height);
+  max-height: var(--pst-header-height);
   width: 100%;
   padding: 0.5rem 0;
   max-width: 100vw;

diff --git a/src/pydata_sphinx_theme/assets/styles/variables/_layout.scss b/src/pydata_sphinx_theme/assets/styles/variables/_layout.scss
@@ -5,7 +5,7 @@ html {
 
   // Header height will impact the top offset for many sections
   // Article header is 66% of Header
-  --pst-header-height: 3rem;
+  --pst-header-height: 4rem;
   --pst-header-article-height: calc(var(--pst-header-height) * 2 / 3);
   --pst-sidebar-secondary: 17rem;
 }