add missing countries

[EssaAlshammri]

as disscused in #11

@yezz123

[yezz123]

Great! Thank you @EssaAlshammri

Can you run pip-tools to refresh the dependencies to fix the CI/CD

[EssaAlshammri]

I'm sorry I didn't grasp that!

@yezz123

[yezz123]

Yes you can install pip-tools and run make refresh-lockfiles then also check using pre-commit if there is any linting issues

[EssaAlshammri]

Oh yeah I did that and it complained about double quotes.
but there are a handfull countries that include single ones.

should I escape them ?

[EssaAlshammri]

When I escape single quotes it says:
Q003 [*] Change outer quotes to avoid escaping inner quotes

and when I enclose them with double ones it says:
Q000 [*] Double quotes found but single quotes preferred

currently it looks like this

CountryInfo(
    'DZ',
    'DZA',
    '012',
    'Algeria',
    "People's Democratic Republic of Algeria",
),

[yezz123]

@EssaAlshammri we can change the configuration regarding ruff in pyproject.toml

[EssaAlshammri]

by using

avoid-escape = false

or

inline-quotes = 'single' => inline-quotes = 'double'
this will make lint break on other files

?

[EssaAlshammri]

or this way

'pydantic_extra_types/types/country.py' = ['Q000']

[yezz123]

or this way

'pydantic_extra_types/types/country.py' = ['Q000']

👍🏻

[EssaAlshammri]

should I push the changes made by make refresh-lockfiles ?

[yezz123]

should I push the changes made by make refresh-lockfiles ?

yes

[EssaAlshammri]

error: Unused "type: ignore" comment from mypy

[yezz123]

error: Unused "type: ignore" comment from mypy

I will fix it later, its regarding some changes in the logic 🙏🏻

Thank you @EssaAlshammri

[EssaAlshammri]

thank you :)

test aren't passing too

[EssaAlshammri]

side note

CountryInfo(
            "XK",
            "UNK",
            "",
            "Kosovo",
            "Republic of Kosovo",
        ),

this country doesn't have a numeric code
and it's not listed in https://www.iso.org/iso-3166-country-codes.html

I guess something has to be done either delete it or write something in that field to indecate it doesn't have one.

• it's the only country that isn't listed in iso.org

[samuelcolvin]

there seem to be a lots of changes here not related to adding countries, and changing quotes is making this change very hard to review.

Also this doesn't really follow what I suggested in #24.

@yezz123 please hold off on merging unless the change is trivial. I think really we need to revert this, or revert a lot of the changes in main.

[samuelcolvin]

this should just be return {'type': 'string', 'format': 'color'}

[samuelcolvin]

why are we using double quotes in this file?