-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semantic version type #199
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 11 17 +6
Lines 685 960 +275
Branches 169 232 +63
==========================================
+ Hits 685 960 +275 ☔ View full report in Codecov by Sentry. |
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @jbkroner can you please address these small enhancements, I would be happy to merge this PR after!
Thanks 👍🏻
@yezz123 fixes applied. apologies for the extra commits - didn't click that I could run the linter / pre-commit stuff locally (duh) following the instructions in the main pydantic repo. |
Adding a semantic version type as requested in #2506 in the pydantic repo.
The implementation here is just the example from the python-semver docs + some additional tests.
When this PR gets a thumbs up I will update the docs in python-semver.
Any feedback appreciated, cheers.
edit: tracking on coverage and 3.8 compatibility issues, will try to get that covered early this week before marking as ready for review.
Selected Reviewer: @yezz123