Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward default_value calls to the underlying schema for DefinitionRefValidator #1573

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Forward default_value calls to the underlying schema for DefinitionRefValidator #1573

merged 1 commit into from
Dec 9, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Dec 8, 2024

Change Summary

Fixes pydantic/pydantic#11051.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1573 will not alter performance

Comparing default-def-reference (f8fe423) with main (4c02cbd)

Summary

✅ 155 untouched benchmarks

@Viicos Viicos force-pushed the default-def-reference branch from 52c96ea to f8fe423 Compare December 9, 2024 08:15
@Viicos Viicos requested a review from sydney-runkle December 9, 2024 08:15
davidhewitt
davidhewitt approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidhewitt davidhewitt merged commit 7f13140 into main Dec 9, 2024
29 checks passed
@davidhewitt davidhewitt deleted the default-def-reference branch December 9, 2024 10:25
@Viicos Viicos added the backport-2.27 Needs backport to 2.27 label Dec 16, 2024
davidhewitt pushed a commit that referenced this pull request Dec 18, 2024
@Viicos @davidhewitt
Forward default_value calls to the underlying schema for `Definitio…
253cfe0 
…nRefValidator` (#1573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

@sydney-runkle sydney-runkle Awaiting requested review from sydney-runkle

Assignees
No one assigned
Labels
backport-2.27 Needs backport to 2.27
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The default value in the annotated type does not apply
2 participants
@Viicos @davidhewitt