Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null arguments using JSON schema #845

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Handle null arguments using JSON schema #845

merged 5 commits into from
Feb 10, 2025

Conversation

alexmojaki
Copy link
Contributor

Just a little simplification of our data model and logic that I've wanted.

Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2025

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: dd5c59c
Status: ✅  Deploy successful!
Preview URL: https://f3132257.logfire-docs.pages.dev
Branch Preview URL: https://alex-null.logfire-docs.pages.dev

View logs

@alexmojaki alexmojaki requested review from Kludex and adriangb February 5, 2025 15:55
Copy link
Member

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alexmojaki alexmojaki merged commit faf859f into main Feb 10, 2025
14 checks passed
@alexmojaki alexmojaki deleted the alex/null branch February 10, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants