add logfire.logfire_info()
#826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
32c3d86
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b0ec147c.logfire-docs.pages.dev |
| Branch Preview URL: | https://logfire-info.logfire-docs.pages.dev |
samuelcolvin
commented
Jan 29, 2025
|
|
||
| ```bash | ||
| logfire info | ||
| ``` | ||
|
|
||
| Or in python run: |
There was a problem hiding this comment.
this will be wrong until we make a release.
Kludex
reviewed
Jan 29, 2025
logfire-api/logfire_api/__init__.py
Outdated
Comment on lines
233
to
235
| def logfire_info() -> str: | ||
| """Show versions of logfire, OS and related packages.""" | ||
| raise NotImplementedError('this method is not implement in logfire-api') |
There was a problem hiding this comment.
Logfire API is meant to be a no-op. Why would it not be possible to call it with logfire-api?
There was a problem hiding this comment.
okay, I'll make it return an empty string.
Kludex
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating #825 I realised there's no nice way to get the
logfire infooutput if you don't have a terminal.