Fix conflict with ddtrace futures patching by renaming fn parameter #802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem reported in https://pydanticlogfire.slack.com/archives/C06EDRBSAH3/p1737061346996829
Before this PR, this:
raises:
Executor.submit
has the signature(self, fn, /, *args, **kwargs)
. Althoughfn
is now positional-only, ddtrace pays special attention to that name in https://github.com/DataDog/dd-trace-py/blob/26dc258020126a7527f973c26494f0dd1016dead/ddtrace/contrib/internal/futures/threading.py#L7-L23So avoiding that name does the trick.