Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unpack from instrument_starlette #737

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Dec 27, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Dec 27, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8bb2545
Status: ✅  Deploy successful!
Preview URL: https://0ff15f16.logfire-docs.pages.dev
Branch Preview URL: https://remove-starlette-unpack.logfire-docs.pages.dev

View logs

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (53075d1) to head (8bb2545).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #737   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          135       135           
  Lines        10866     10867    +1     
  Branches      1538      1538           
=========================================
+ Hits         10866     10867    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kludex Kludex requested a review from alexmojaki December 27, 2024 13:30
@Kludex Kludex merged commit 1ec90f4 into main Dec 27, 2024
14 checks passed
@Kludex Kludex deleted the remove-starlette-unpack branch December 27, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants