Skip to content

Commit

Permalink
Fix compatibility with Pydantic dropping 3.8 (#804)
Browse files Browse the repository at this point in the history
Pydantic dropped support for Python 3.9 (and will be effective when 2.11 is released). Because the Logfire SDK still supports 3.8 and as we pin Pydantic to the main branch in our dev dependencies, we need to add a conditional based on the python version.
  • Loading branch information
Viicos authored Jan 17, 2025
1 parent cccccd0 commit 6b263c0
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/daily_deps_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
pydantic-version: ['main']
include:
- python-version: '3.12'
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ dev = [
"pytest >= 8.3.4",
"pytest-django >= 4.6.0",
"pytest-pretty >= 1.2.0",
"pydantic @ git+https://github.com/pydantic/pydantic",
"pydantic @ git+https://github.com/pydantic/pydantic ; python_version >= '3.9'",
"pydantic==2.10.5; python_version < '3.9'",
"requests >= 2.31.0",
"sqlalchemy >= 1.4.54",
"pandas>=2.1.2; python_version >= '3.9'",
Expand Down
60 changes: 48 additions & 12 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6b263c0

Please sign in to comment.