Skip to content

Commit

Permalink
Drop experimental warning from CodeSource (#752)
Browse files Browse the repository at this point in the history
  • Loading branch information
Kludex authored Dec 30, 2024
1 parent 1fd9642 commit 4e4ea49
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 20 deletions.
6 changes: 0 additions & 6 deletions docs/how-to-guides/link-to-code-source.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
!!! warning "Experimental"
This feature is experimental and may change in the future.

If you have any feedback or suggestions, please [let us know][help].

We support linking to the source code on GitHub, GitLab, and any other VCS provider that uses the same URL format.

![Link to GitHub](../images/guide/link-to-github.gif)
Expand Down Expand Up @@ -40,5 +35,4 @@ OTEL_RESOURCE_ATTRIBUTES=${OTEL_RESOURCE_ATTRIBUTES},vcs.repository.ref.revision
OTEL_RESOURCE_ATTRIBUTES=${OTEL_RESOURCE_ATTRIBUTES},vcs.root.path=.
```

[help]: ../help.md
[otel-resource-attributes]: https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/#general-sdk-configuration
8 changes: 1 addition & 7 deletions logfire-api/logfire_api/_internal/config.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,7 @@ class MetricsOptions:

@dataclass
class CodeSource:
"""Settings for the source code of the project.
!!! Warning
This setting is experimental, and may change in the future!
"""
"""Settings for the source code of the project."""
repository: str
revision: str
root_path: str = ...
Expand Down Expand Up @@ -131,8 +127,6 @@ def configure(*, local: bool = False, send_to_logfire: bool | Literal['if-token-
sampling: Sampling options. See the [sampling guide](https://logfire.pydantic.dev/docs/guides/advanced/sampling/).
code_source: Settings for the source code of the project.
!!! Warning
This setting is experimental, and may change in the future!
advanced: Advanced options primarily used for testing by Logfire developers.
"""

Expand Down
8 changes: 1 addition & 7 deletions logfire/_internal/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,7 @@ class MetricsOptions:

@dataclass
class CodeSource:
"""Settings for the source code of the project.
!!! Warning
This setting is experimental, and may change in the future!
"""
"""Settings for the source code of the project."""

repository: str
"""The repository URL for the code e.g. https://github.com/pydantic/logfire"""
Expand Down Expand Up @@ -291,8 +287,6 @@ def configure( # noqa: D417
sampling: Sampling options. See the [sampling guide](https://logfire.pydantic.dev/docs/guides/advanced/sampling/).
code_source: Settings for the source code of the project.
!!! Warning
This setting is experimental, and may change in the future!
advanced: Advanced options primarily used for testing by Logfire developers.
"""
from .. import DEFAULT_LOGFIRE_INSTANCE, Logfire
Expand Down

0 comments on commit 4e4ea49

Please sign in to comment.