hack: don't coerce utf8 view inside dictionary

pydantic · Feb 10, 2025 · 8bb70a2 · 8bb70a2
1 parent 5239d1a
commit 8bb70a2
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/datafusion/expr-common/src/type_coercion/binary.rs b/datafusion/expr-common/src/type_coercion/binary.rs
@@ -146,7 +146,7 @@ impl<'a> BinaryTypeCoercer<'a> {
         }
         And | Or => if matches!((self.lhs, self.rhs), (Boolean | Null, Boolean | Null)) {
             // Logical binary boolean operators can only be evaluated for
-            // boolean or null arguments.                   
+            // boolean or null arguments.
             Ok(Signature::uniform(Boolean))
         } else {
             plan_err!(
@@ -502,6 +502,14 @@ pub fn type_union_resolution(data_types: &[DataType]) -> Option<DataType> {
         }
     }
 
+    // HACK: DataType::Utf8View is not a meaningful dictionary value type, so
+    // just pull this out if we dict-encoded it
+    if let Some(DataType::Dictionary(_, value_type)) = &candidate_type {
+        if value_type.as_ref() == &DataType::Utf8View {
+            candidate_type = Some(DataType::Utf8View);
+        }
+    }
+
     candidate_type
 }