Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: open space #556

Merged
merged 5 commits into from
Aug 15, 2024
Merged

feat: open space #556

merged 5 commits into from
Aug 15, 2024

Conversation

Ritabear
Copy link
Collaborator

@Ritabear Ritabear commented Jul 16, 2024 •
edited
Loading

Types of changes

  • open the page of the open space
  • open space i18n

Description

  • wait for more information to update pages
  • After the other updates of the document, I will recheck the page.

Related Issue

#532

@Ritabear Ritabear requested a review from SivanYeh July 16, 2024 13:25
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for classy-granita-bc2b5a ready!

Name Link
🔨 Latest commit 272ae1f
🔍 Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/66bb9f07f2b4420009fd9202
😎 Deploy Preview https://deploy-preview-556--classy-granita-bc2b5a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit 272ae1f
🔍 Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/66bb9f07c94db20008dab77f
😎 Deploy Preview https://deploy-preview-556--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SivanYeh
Copy link
Collaborator

文案上週有更新一版：https://docs.google.com/document/d/1WHCKUe2zYoG88bPHJfsvYm7doN7XcoeUkBuGDR5xt8w/edit

我把更新的部分標註下

SivanYeh
SivanYeh requested changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@SivanYeh SivanYeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ritabear 最後一哩路了：

  1. 把剩下4條我還沒刪除或resolve的comments 修改完成
  2. 到codebase查詢任何複數型Open Spaces, 將它改成單數. 例如：NavBar.i18n.js裡面的Open Spaces
image

i18n/events/open-spaces.i18n.js Outdated Show resolved Hide resolved
i18n/events/open-spaces.i18n.js Outdated Show resolved Hide resolved
i18n/events/open-spaces.i18n.js Outdated Show resolved Hide resolved
i18n/events/open-spaces.i18n.js Outdated Show resolved Hide resolved
@Ritabear Ritabear marked this pull request as ready for review July 29, 2024 06:53
@Ritabear Ritabear requested a review from mattwang44 August 14, 2024 03:42
@Ritabear Ritabear requested a review from SivanYeh August 14, 2024 05:57
@mattwang44 mattwang44 merged commit 0aa6a4b into main Aug 15, 2024
9 checks passed
@mattwang44 mattwang44 deleted the feat/open_space branch August 15, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwang44 mattwang44 mattwang44 approved these changes

@SivanYeh SivanYeh Awaiting requested review from SivanYeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ritabear @SivanYeh @mattwang44