feat(venue): update venue i18n string and svg to 2024 #533
Conversation
✅ Deploy Preview for classy-granita-bc2b5a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
af1417b to
d1b05a0
Compare
i18n/venue/index.i18n.js
Outdated
| @@ -8,9 +8,8 @@ export default genI18nMessages({ | |||
| 'PyCon Taiwan 2023 will be held at the Humanities and Social Science Building, Academia Sinica, with a focus on the latest technology and best practices in Python. The open-source community will bring high-quality speeches and workshops, providing valuable learning and networking opportunities for both novice and experienced Python developers.', | |||
There was a problem hiding this comment.
Might have to inquire the description of 2024 from team venue.
There was a problem hiding this comment.
This would be updated at 23da2ac
plz check.
There was a problem hiding this comment.
I think we should minimize the difference between Zh/En.
How about that?
'PyCon Taiwan 2024 will be held at the National Science and Technology Museum (South Complex), with a focus on the latest technology and best practices in Python. The open-source community will bring high-quality speeches and workshops, providing valuable learning and networking opportunities for both novice and experienced Python developers.'
i18n/venue/index.i18n.js
Outdated
| @@ -143,8 +120,8 @@ export default genI18nMessages({ | |||
| 'PyCon Taiwan 2023 將在中央研究院人文社會科學館舉辦，聚焦於 Python 的最新技術和最佳實踐，讓開源社群帶來高品質的演講和工作坊，無論您是 Python 的新手還是資深開發人員，都能在這裡找到有價值的學習和交流機會。', | |||
There was a problem hiding this comment.
This would be updated at 23da2ac
plz check.
| info1: 'the traffic information of Academia Sinica', | ||
| info2: 'the public transportation information of Taoyuan international Airport', | ||
| title: 'For more information, please refer to {0}。', | ||
| info1: 'the traffic information of national science and technology museum.', | ||
| }, | ||
| }, | ||
| shuttleService: { |
There was a problem hiding this comment.
shuttleTime needs to be updated
There was a problem hiding this comment.
There will be no shuttle tab in 2024.
i've remove the entry.
279b72e to
23da2ac
Compare
e0ec837 to
243b889
Compare
|
Awesome! I will deploy the PR after two mild changes:
|
updated. |
Types of changes
TODO:
Description
Fix: #524
This PR aims to add features in venue page in 2024.
The change will be impacted on the following page.
Steps to Test This Pull Request
Go to the path /venue or /venue/accommodation
Expected behavior
Related Issue
Additional context