Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting page_size with unlimited paging #894

Closed
wants to merge 1 commit into from

Conversation

eagleonhill
Copy link

By default, it will use the whatever the first maxResults that server returns.
This can be far less than what the server is capable of, and fetching in small batch is very inefficient.

@eagleonhill eagleonhill requested review from ssbarnea and dbaxa and removed request for ssbarnea January 23, 2020 23:26
@adehad adehad added enhancement Status: Ready for Merge PR looks good to merge labels May 2, 2021
@ssbarnea ssbarnea closed this May 15, 2021
@ssbarnea ssbarnea reopened this May 15, 2021
@studioj
Copy link
Collaborator

studioj commented May 24, 2021

@eagleonhill please merge in changes from master.
could it be you change also requires a documentation update?

@ssbarnea ssbarnea removed the Status: Ready for Merge PR looks good to merge label May 24, 2021
@studioj studioj added the stale Ticket that is likely to go nowhere and that will be closed soon label Oct 30, 2021
@adehad
Copy link
Contributor

adehad commented Jun 5, 2022

closing as probably will be superseded by #1394

@adehad adehad closed this Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale Ticket that is likely to go nowhere and that will be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants